[Snyk] Fix for 1 vulnerabilities#5406
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TARFS-10293725
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Reviewer's GuideThis PR remediates a high-severity Zip-slip vulnerability by replacing workspace ranges with explicit 0.1.1 versions for two Backstage dependencies in the permission-common plugin’s package.json. Sequence Diagram: Snyk's Automated Dependency Update ProcesssequenceDiagram
actor SnykBot as "Snyk Service"
participant Repo as "GitHub Repository"
participant PkgJson as "plugins/permission-common/package.json"
SnykBot->>Repo: Scan project for vulnerabilities
activate Repo
Repo->>PkgJson: Read current dependencies
activate PkgJson
PkgJson-->>Repo: Current: @backstage/config ("workspace:^"), @backstage/types ("workspace:^")
deactivate PkgJson
Repo-->>SnykBot: Report current dependencies
deactivate Repo
SnykBot->>SnykBot: Identify vulnerability & determine fix (update to "0.1.1")
SnykBot->>Repo: Create Pull Request
activate Repo
Repo->>PkgJson: Update @backstage/config: "workspace:^" to "0.1.1"
activate PkgJson
PkgJson-->>Repo: @backstage/config updated in PR
deactivate PkgJson
Repo->>PkgJson: Update @backstage/types: "workspace:^" to "0.1.1"
activate PkgJson
PkgJson-->>Repo: @backstage/types updated in PR
deactivate PkgJson
Repo-->>SnykBot: Pull Request created with updated package.json
deactivate Repo
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| "@backstage/config": "0.1.1", | ||
| "@backstage/errors": "workspace:^", | ||
| "@backstage/types": "workspace:^", | ||
| "@backstage/types": "0.1.1", |
There was a problem hiding this comment.
Replacing workspace:^ references with fixed versions (0.1.1) breaks the monorepo's workspace dependency pattern, which can lead to:
- Package duplication in the dependency tree
- Version mismatches between components
- Potential compatibility issues with other parts of the codebase
This approach addresses the vulnerability but introduces architectural inconsistency. Consider either:
- Updating the vulnerable dependency while maintaining the workspace references
- Using a more recent version that addresses the vulnerability
- Applying a targeted patch rather than changing the dependency structure
The warning about failing to update yarn.lock in the PR description further suggests this approach may cause integration problems.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/permission-common/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TARFS-10293725
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Improper Link Resolution Before File Access ('Link Following')
Summary by Sourcery
Patch a critical security issue by updating dependency versions in the permission-common package.
Bug Fixes:
Enhancements: